-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(contracts,unlock-js): cleanup deprec versions #14050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WAIT! Did you check that none of the old versions are active?
here is the check results (failng for Polygon rn)
|
…nlock into remove-deprec-versions
…nlock into remove-deprec-versions
For Unlock versions, this is a different pattern than templates as we shouldnt need to support any older versions |
That's a very good point! For the sake of transparency let's keep 3 versions (current + 2 previous ones) just in case? wdyt? |
ok so if we want to go ahead and remove support for v8 (but keep v9 for now) we end up with that list: BNB Chain (56):
Gnosis Chain (100):
Ethereum (1):
Optimism (10):
Polygon (137):
|
closing in favor of incremental approach -- see #14455 |
Description
This PR removes references from versions before Unlock v10 and PublicLock v9 from the main distributed packages.
Issues
Fixes #
Refs #13445
Checklist:
Release Note Draft Snippet